[14.0][MIG] event_mail: Migration to 14.0 #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sergio-teruel @chienandalu could you review, please? |
ivantodorovich
approved these changes
Nov 22, 2021
| for scheduler in self.event_mail_template_id.scheduler_template_ids: | ||
| vals.append( | ||
| @api.depends("event_mail_template_id") | ||
| def _compute_event_mail_ids(self): |
There was a problem hiding this comment.
Nitpicking here but you could do this to split the water, it's slightly cleaner:
records = self.filtered("event_mail_template_id")
without_template = self - records
Currently translated at 100.0% (22 of 22 strings) Translation: event-10.0/event-10.0-event_mail Translate-URL: https://translation.odoo-community.org/projects/event-10-0/event-10-0-event_mail/fr/
Currently translated at 100.0% (22 of 22 strings) Translation: event-10.0/event-10.0-event_mail Translate-URL: https://translation.odoo-community.org/projects/event-10-0/event-10-0-event_mail/es/
ernestotejeda
force-pushed
the
14.0-mig-event_mail
branch
from
787b4c7
to
29e8c6d
Compare
|
@ivantodorovich changes done |
CarlosRoca13
approved these changes
Dec 23, 2021
|
This PR has the |
|
/ocabot migration event_mail /ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 235e869. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cc @Tecnativa TT32127
Main changes: